Skip to content

Cloud: Import ux optimization #21361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: release-8.1
Choose a base branch
from
Open

Conversation

xuanyu66
Copy link

@xuanyu66 xuanyu66 commented Jul 9, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jul 9, 2025
Copy link

ti-chi-bot bot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiancai for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 9, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @xuanyu66, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the user experience documentation for the cloud import feature in TiDB Cloud Serverless. The changes reflect an optimized import wizard flow, making it easier for users to understand and follow the steps for importing data from Amazon S3, Google Cloud Storage, Azure Blob Storage, and Alibaba Cloud OSS. The updates aim to provide clearer instructions for source file specification, credential handling, and flexible destination mapping options.

Highlights

  • Documentation Update for Cloud Import UX: The pull request updates the documentation for the TiDB Cloud Serverless data import feature, focusing on user experience optimizations across various cloud storage providers.
  • Streamlined Import Process Steps: The documented steps for importing data from Amazon S3, Google Cloud Storage, Azure Blob Storage, and Alibaba Cloud OSS have been revised to reflect a more streamlined and intuitive user interface flow, including changes to button labels (e.g., 'Connect' to 'Next') and the sequence of operations.
  • Improved Clarity on Input Fields and Mapping: The documentation now provides clearer guidance on entering source file URIs, selecting credentials, and configuring destination mapping. It explicitly differentiates between manual mapping for non-standard file naming conventions and automatic mapping when using TiDB Dumpling conventions, along with updated wildcard examples.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@xuanyu66 xuanyu66 added area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 9, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The code changes update the documentation for importing CSV files to TiDB Cloud Serverless, focusing on UX optimization. The changes involve refining the steps for configuring cloud storage access and specifying source file URIs for Amazon S3, Google Cloud Storage, Azure Blob Storage, and Alibaba Cloud OSS. The documentation is updated to reflect the new UI and workflow.

xuanyu66 and others added 5 commits July 9, 2025 15:21
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 9, 2025
@xuanyu66 xuanyu66 requested review from qiancai and zhangyangyu July 10, 2025 02:43
@qiancai qiancai added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jul 10, 2025
@xuanyu66 xuanyu66 requested a review from qiancai July 11, 2025 02:46
@xuanyu66
Copy link
Author

@qiancai PTAL

@qiancai qiancai force-pushed the import-ux-optimization branch from ecbc7ee to c961f21 Compare July 11, 2025 06:52
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 11, 2025
Copy link

ti-chi-bot bot commented Jul 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-11 07:10:06.574644838 +0000 UTC m=+2242859.297823818: ☑️ agreed by qiancai.

github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request Jul 11, 2025
@qiancai qiancai self-assigned this Jul 11, 2025
@qiancai qiancai requested a review from lilin90 July 11, 2025 08:33
@qiancai qiancai added the needs-cherry-pick-release-cloud Should cherry pick this PR to release-cloud branch. label Jul 11, 2025
Copy link

ti-chi-bot bot commented Jul 13, 2025

@zhangyangyu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tidb-cloud This PR relates to the area of TiDB Cloud. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. for-cloud-release This PR is related to TiDB Cloud release. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-cloud Should cherry pick this PR to release-cloud branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants