Skip to content

fix cdc redo log storage configuration #12653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 8, 2023
Merged

fix cdc redo log storage configuration #12653

merged 4 commits into from
Feb 8, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Jan 12, 2023 •
edited by shichun-0415
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

ticdc support use gcs/azure as external storage in redo log.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions) Merge only after release of 6.5.1
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions) Merge only after release of 6.1.4
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn January 12, 2023 07:58
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2023
@TomShawn TomShawn requested a review from shichun-0415 January 12, 2023 08:23
@TomShawn TomShawn added area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. v6.6 translation/doing This PR’s assignee is translating this PR. for-release This PR relates to a TiDB release but does not have a tracked feature. and removed missing-translation-status This PR does not have translation status info. labels Jan 12, 2023
@shichun-0415 shichun-0415 self-assigned this Jan 12, 2023
@TomShawn TomShawn added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jan 30, 2023
@shichun-0415
Copy link
Contributor

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2023
Oreoxmt
Oreoxmt reviewed Feb 2, 2023
View reviewed changes
Oreoxmt
Oreoxmt reviewed Feb 3, 2023
View reviewed changes
@Oreoxmt Oreoxmt self-requested a review February 3, 2023 03:28
@shichun-0415 shichun-0415 removed the request for review from TomShawn February 3, 2023 08:35
shichun-0415
shichun-0415 reviewed Feb 3, 2023
View reviewed changes
@shichun-0415 shichun-0415 mentioned this pull request Feb 3, 2023
Merged
14 tasks
@shichun-0415 shichun-0415 added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 3, 2023
@CharlesCheung96 @shichun-0415 @Oreoxmt
Apply suggestions from code review
99e71ea 
Co-authored-by: shichun-0415 <[email protected]>
Co-authored-by: Aolin <[email protected]>
shichun-0415
shichun-0415 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 3, 2023
Oreoxmt
Oreoxmt reviewed Feb 8, 2023
View reviewed changes
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2943804

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@ti-chi-bot ti-chi-bot merged commit 755cb1d into pingcap:master Feb 8, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 8, 2023
Open
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #12961.

This was referenced Feb 8, 2023
Merged
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #12962.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Feb 8, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#12653
ede2818 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot added a commit that referenced this pull request Feb 8, 2023
@ti-chi-bot
fix cdc redo log storage configuration (#12653) (#12962)
ee130dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

+1 more reviewer

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@shichun-0415 shichun-0415

Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. for-release This PR relates to a TiDB release but does not have a tracked feature. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CharlesCheung96 @ti-chi-bot @shichun-0415 @Oreoxmt @nongfushanquan @TomShawn