Point package.json at pinecone-ts-client branch, adjust for breaking changes #24
Merged
austin-denoble merged 2 commits intomainfrom Jan 27, 2026
Merged
Conversation
…pdate code to account for breaking changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There are upcoming breaking changes to operations in
pinecone-ts-clientthat impact this external app. Until the new release is actually available, it would be helpful to tie this application to the specific branch that includes the breaking changes:"@pinecone-database/pinecone": "git+https://github.com/pinecone-io/pinecone-ts-client.git#adenoble/update-data-plane-namespace-targeting".Solution
Update
package.jsonto pull in breaking changes viapinecone-ts-clientbranch (adenoble/update-data-plane-namespace-targeting).Update calls to
upsertto pass{ records: [...]}.Type of Change
Test Plan
Push and allow CI to run. This application will also be validated through the
pinecone-ts-clientCI pipeline: https://github.com/pinecone-io/pinecone-ts-client/blob/main/.github/actions/external-app/edge/action.yml#L30-L66