Remove beforeAll() global index cleanup from "semantic search" test#20
Merged
austin-denoble merged 1 commit intomainfrom Dec 23, 2025
Merged
Conversation
Coverage Report
File CoverageNo changed files found. |
beforeAll() global index cleanup from "semantic search" test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The semantic search integration test had a
beforeAll()hook which was listing and cleaning up all indexes within whatever API key was set. This is error-prone, and a little surprising and destructive if you're testing with a key while not expecting that to happen.It's also caused flakiness in the external app test in the typescript SDK repo.
Solution
Remove the
beforeAll()hook. TheafterAll()hook is cleaning up any indexes that were loaded/created as a part of the test anyways.Type of Change
Test Plan
n/a