Add embed to Index configure calls
#515
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igure method, and building in the request factory
…how we're building the configure index request call to be a bit more flexible
…s ConfigureIndexRequestEmbed as the class to the generated core
… interface and asyncio interface to support the embed parameter on configure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
embedwas never exposed as an argument for callingconfigureonIndexResource.Solution
Add a new simple
ConfigureIndexEmbed(TypedDict)class for representing the argument structure.Update factory, sync, and async resources to pass through
embedonconfigurecalls.Type of Change
Test Plan