Fix EL133UF1 sending POF mid-refresh on 13.3" displays - #265
Merged
Conversation
The BUSY line on the EL133UF1 (Impression 13.3") is active-LOW during a refresh: it drops LOW while the panel updates and returns HIGH when done. `_busy_wait` treats the line as active-HIGH, so after DRF it returns instantly and POF is sent mid-refresh on every update. The panel usually ignores it but occasionally latches into a fault (BUSY pinned HIGH, ignoring RST_N/POF/deep-sleep) that only full power removal recovers. Add `_refresh_wait`, which polls the line correctly (assert busy LOW, then wait for it to clear HIGH, with a timeout warning) and use it after DRF. `_busy_wait` is left unchanged for PON/POF, since post-POF the line rests LOW and would be ambiguous under an inverted global check.
Contributor
|
Thank you! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BUSY line on the EL133UF1 (Impression 13.3") is active-LOW during a refresh: it drops LOW while the panel updates and returns HIGH when done.
_busy_waittreats the line as active-HIGH, so after DRF it returns instantly and POF is sent mid-refresh on every update. The panel usually ignores it but occasionally latches into a fault (BUSY pinned HIGH, ignoring RST_N/POF/deep-sleep) that only full power removal recovers.Add
_refresh_wait, which polls the line correctly (assert busy LOW, then wait for it to clear HIGH, with a timeout warning) and use it after DRF._busy_waitis left unchanged for PON/POF, since post-POF the line rests LOW and would be ambiguous under an inverted global check.potentially closes #254