Skip to content

Fix grammar, style, and formatting in Approximate Matching doc #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 22, 2025

Conversation

its-dave
Copy link
Contributor

@its-dave its-dave commented May 4, 2025

What does this PR aim to accomplish?:

Tidy the wording and syntax in docs/regex/approximate.md as some of it didn't make sense or was inconsistent


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Sorry, something went wrong.

its-dave added 2 commits May 3, 2025 19:31
Signed-off-by: Dave <18191844+its-dave@users.noreply.github.com>
Signed-off-by: Dave <18191844+its-dave@users.noreply.github.com>
Copy link

netlify bot commented May 4, 2025

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit bec4096
🔍 Latest deploy log https://app.netlify.com/projects/pihole-docs/deploys/687f9bbe79fd6000082781d6
😎 Deploy Preview https://deploy-preview-1240--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rdwebdesign rdwebdesign requested review from DL6ER and a team May 5, 2025 00:54
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: Dave <18191844+its-dave@users.noreply.github.com>
@yubiuser yubiuser requested a review from rdwebdesign May 6, 2025 14:27
@rdwebdesign
Copy link
Member

I'd like to know @DL6ER opinion here, because he is the original author of this page.

@rdwebdesign rdwebdesign removed their request for review May 18, 2025 01:26
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Dave <18191844+its-dave@users.noreply.github.com>
Copy link
Contributor

Conflicts have been resolved.

@its-dave
Copy link
Contributor Author

@rdwebdesign @DL6ER happy with my changes?

@yubiuser
Copy link
Member

One formal change: please squash down all your commits

Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not even seen the first @-ping. I am not a native speaker and everybody is happily invited to improve my texts in any helpful way!

@its-dave
Copy link
Contributor Author

@yubiuser I don't think I can squash from the UI, are you able to squash when merging?

@rdwebdesign rdwebdesign requested a review from PromoFaux July 19, 2025 22:01
@rdwebdesign
Copy link
Member

I don't see any issues, but I'm also not a native speaker. Maybe @PromoFaux can check the text to make sure.

@PromoFaux
Copy link
Member

Looks good to me

@PromoFaux
Copy link
Member

And yes, we can do a squash merge - no worries there

@its-dave
Copy link
Contributor Author

Thanks, and thanks all for all your work on this project!

@yubiuser yubiuser dismissed rdwebdesign’s stale review July 22, 2025 14:09

Changes have been addressed and/or resolved

@yubiuser yubiuser merged commit c13460a into pi-hole:master Jul 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants