-
-
Notifications
You must be signed in to change notification settings - Fork 226
Fix grammar, style, and formatting in Approximate Matching doc #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dave <18191844+its-dave@users.noreply.github.com>
Signed-off-by: Dave <18191844+its-dave@users.noreply.github.com>
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: RD WebDesign <github@rdwebdesign.com.br> Signed-off-by: Dave <18191844+its-dave@users.noreply.github.com>
I'd like to know @DL6ER opinion here, because he is the original author of this page. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Dave <18191844+its-dave@users.noreply.github.com>
Conflicts have been resolved. |
@rdwebdesign @DL6ER happy with my changes? |
One formal change: please squash down all your commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not even seen the first @-ping. I am not a native speaker and everybody is happily invited to improve my texts in any helpful way!
@yubiuser I don't think I can squash from the UI, are you able to squash when merging? |
I don't see any issues, but I'm also not a native speaker. Maybe @PromoFaux can check the text to make sure. |
Looks good to me |
And yes, we can do a squash merge - no worries there |
Thanks, and thanks all for all your work on this project! |
Changes have been addressed and/or resolved
What does this PR aim to accomplish?:
Tidy the wording and syntax in
docs/regex/approximate.md
as some of it didn't make sense or was inconsistentBy submitting this pull request, I confirm the following:
git rebase
)