fix hosted Rust CI setup ordering - #105
Open
odyslam wants to merge 1 commit into
Open
Conversation
odyslam
requested review from
fredo,
lean-apple,
makemake-kbo,
mateo-mro and
penumbra23
as code owners
July 21, 2026 16:47
lean-apple
approved these changes
Jul 21, 2026
mateo-mro
reviewed
Jul 22, 2026
| if: ${{ inputs.deny-preinstalled == true }} | ||
| - name: Install cargo-binstall | ||
| if: ${{ inputs.deny-preinstalled != true }} | ||
| uses: cargo-bins/cargo-binstall@732870f031d2fb36309d0deaf36abcc704a7be65 # v1.20.1 |
Contributor
There was a problem hiding this comment.
The action reference is pinned, but its version input is omitted, so it downloads the latest cargo binstall binary. The following command also installs the latest cargo deny release. That leaves this organization wide reusable workflow able to change without a commit here. Please pin both tool versions so the workflow stays reproducible and the pinned action reference provides the intended supply chain boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --checkactionlint .github/workflows/rust-base.yamlreaches one pre-existing dynamicservices.volumestype warning at line 152This unblocks phylaxsystems/pcl#115 after moving public-repository CI off privileged self-hosted ARC runners.
Resolves ENG-4654