From<String> implemenation for InstructionParseError#2
Open
DamonPalovaara wants to merge 1 commit intophy1um:mainfrom
Open
From<String> implemenation for InstructionParseError#2DamonPalovaara wants to merge 1 commit intophy1um:mainfrom
DamonPalovaara wants to merge 1 commit intophy1um:mainfrom
Conversation
…p_error since Rust can now type coerce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently you are doing manual type coercion to make your errors compatible. My pull request implements From for InstructionParseError so that the Rust compiler can coerce the errors automatically.