Always use element namespace as target namespace #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes phpro/soap-client#585
Previously, this resulted in the element scpSimpleQueryRequest being targeted to the
scpbase
namespace.This is not correct, given that the element is axtyally in the
simple
namespace, which results in the type collection not being able to find this element. (only the complexType in scpbase).This fixes that issue and makes sure the element is also encoded as scpSimple in the encoder.