fix: disable migration lock by default on CheckRepoStatus #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 💙 💜 💛 ❤️ |
|
Please give it a try for a while in your app and let us know if it all goes well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The default behavior of using locks when checking migration status caused a hard
to debug bug when
migration_lock: :pg_advisory_lockwas set on the repo config.The bug was causing multiple slow downs on web requests due to attempts to acquire locks
on the database.
Generally locks should not be necessary for the pending migration check since we
are just reading from the migrations table and not actually running the migrations.
Note
I wasn't sure if we should just deprecate the option altogether. For now that means that users can still enable
migration_lockif they find a need for it - I'm not sure if that need really exists. Open to change that.Changes
Made
:migration_lockoption onCheckRepoStatusdefault totrue.