Skip to content

<< is deprecated, we should be using .add#98

Open
wesleyeewong wants to merge 1 commit intophillipp:masterfrom
freeletics:use-add-instead
Open

<< is deprecated, we should be using .add#98
wesleyeewong wants to merge 1 commit intophillipp:masterfrom
freeletics:use-add-instead

Conversation

@wesleyeewong
Copy link

As specified in the ActiveModel::Errors class using << is deprecated, we should be using g.add instead.

https://github.com/rails/rails/blob/6-1-stable/activemodel/lib/active_model/errors.rb#L645-L651

I added the model_name method so the specs would pass, it is trying to resolve model_name somewhere, and fails b/c it's an anonymous class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant