feat: implement MIME type blacklist for MIMEtypes that shouldn't be allowed to navigate and execute HTML/JS#24
Merged
jkadamczyk merged 2 commits intomasterfrom Jan 26, 2026
Conversation
📝 WalkthroughWalkthroughAdded MIME type safety validation to WebView navigation policy: Content-Type is extracted from HTTP responses, normalized, and compared against a static blocklist. Unsafe MIME types now trigger the existing file-download event (when configured) and cancel navigation; this integrates with attachment and canShowMIMEType checks. Changes
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
iamacook
approved these changes
Jan 26, 2026
alexz-phantom
approved these changes
Jan 26, 2026
alexz-phantom
left a comment
There was a problem hiding this comment.
As always with these kinds of things there may be evasions, but this is a definite point improvement. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.