Skip to content

some improvements #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ciruz wants to merge 7 commits into
base: master
Choose a base branch
from
Open

some improvements #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
479ed6d
remove eslintcache
ciruz Jan 13, 2021
dd18366
ignore eslintcache
ciruz Jan 13, 2021
df42054
use isNaN
ciruz Jan 13, 2021
55b0470
consistent spacing
ciruz Jan 13, 2021
e6d7d8e
console.log removed
ciruz Jan 13, 2021
ed155ef
<h1> cannot appear as a descendant of <p>
ciruz Jan 13, 2021
eb97d58
width / height needs to be a number not a string
ciruz Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintcache
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,5 @@
npm-debug.log*
yarn-debug.log*
yarn-error.log*

.eslintcache
11 changes: 5 additions & 6 deletions src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ export default function App() {
"https://raw.githubusercontent.com/owid/covid-19-data/master/public/data/vaccinations/vaccinations.csv",
{
complete: (results) => {
console.log(results.data);
return setAllVaccineData(results.data);
},
}
Expand Down Expand Up @@ -118,7 +117,7 @@ export default function App() {
/>
</span>
<span className="time-to-heard-unit">
&nbsp;days{" "}
{" "}days{" "}
<ExclamationCircleOutlined
data-tip="Days = [(Population * 0.7) - (Vaccine Doses Delivered * 0.5)] / (Average Daily Vaccine Doses Given * 0.5) "
style={{
Expand All @@ -129,7 +128,7 @@ export default function App() {
/>
</span>
</div>
<p className="subheader">
<div className="subheader">
until <h1 className="dummy-h1">herd immunity to Covid-19</h1>{" "}
is reached through vaccinations in{" "}
<span className="selected-country-text">
Expand All @@ -138,7 +137,7 @@ export default function App() {
setSelectedCountry={setSelectedCountry}
/>
</span>
</p>
</div>
<span className="asterisk">
*at current daily vaccination rates
</span>
Expand Down Expand Up @@ -195,7 +194,7 @@ export default function App() {
value={herdImmunityThresholdPercentage}
onChange={(valueAsNumber) => {
if (
valueAsNumber === NaN ||
isNaN(valueAsNumber) ||
valueAsNumber > 95 ||
valueAsNumber < 50
) {
Expand Down Expand Up @@ -224,7 +223,7 @@ export default function App() {
selectedCountry={selectedCountry}
/>
<span className="footer-link-container">
Supported by &nbsp;
Supported by {" "}
<a
className="footer-link"
target="_blank"
Expand Down
4 changes: 2 additions & 2 deletions src/components/map-chart/map-chart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ export const MapChart = ({
<>
<ComposableMap
data-tip=""
width="1150"
height="800"
width={1150}
height={800}
projectionConfig={{ scale: 260 }}
>
<ZoomableGroup>
Expand Down
1 change: 0 additions & 1 deletion src/components/time-to-herd/time-to-herd.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ export const TimeToHerdCount = ({
vaccineDosesDelivered,
dailyVaccinationRate
) => {
console.log("threshold " + herdImmunnityVaccinationThreshold);
let daysRounded = Math.round(
(herdImmunnityVaccinationThreshold - vaccineDosesDelivered) /
dailyVaccinationRate
Expand Down