Fix broken example of simpledemo.lua to work with "simple demo layout"#1342
Open
hansonchar wants to merge 1 commit intopgf-tikz:masterfrom
Open
Fix broken example of simpledemo.lua to work with "simple demo layout"#1342hansonchar wants to merge 1 commit intopgf-tikz:masterfrom
hansonchar wants to merge 1 commit intopgf-tikz:masterfrom
Conversation
Author
|
I've subsequently forced push a better fix. Waiting for Github workflow to complete. |
Signed-off-by: Hanson Char <hanson.char@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I tried out the example at 36.2.1 The Hello World of Graph Drawing but it didn't compile:
It seems to me the culprit is the implementation in SimpleDemo.lua#L25-L39 differs from that in the documentation.
Checklist