Skip to content

Claude-generated cleanup of integration test scripts in favor of single script #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jaggederest
Copy link
Contributor

Don't feel too obliged to merge or intensively review this - if there are issues I can regenerate as needed based on feedback, this is really just a spike.

@jaggederest jaggederest requested review from levkk and Copilot July 15, 2025 04:29
@CLAassistant
Copy link

CLAassistant commented Jul 15, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates multiple integration test scripts into a single test runner and strengthens setup, utility, cleanup, and prerequisite checks.

  • Adds a unified integration/test script to run and clean up tests across languages.
  • Enhances setup.sh with error rollback and updates common.sh with improved process management utilities.
  • Introduces cleanup.sh, refines prerequisite checks, and updates documentation.

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
integration/test New single-command integration test runner
integration/setup.sh Improved setup with error handling and rollback
integration/common.sh Enhanced utilities for starting/stopping PgDog/tests
integration/cleanup.sh New script to teardown test environment
integration/check-prerequisites.sh Expanded checks for tools, ports, and permissions
integration/README.md Documentation updates for usage and prerequisites
Comments suppressed due to low confidence (2)

integration/README.md:9

  • The README references './test' but the actual test runner script is located at 'integration/test'. Update the path to './integration/test' to match the repository structure.
./test

integration/setup.sh:78

  • The PGUSER export is commented out, so psql may default to the OS user. Consider exporting PGUSER='pgdog' to ensure all setup commands consistently connect as the pgdog superuser.
export PGPORT=5432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants