Fix primary_key regression test to align with Spock 5.0 behavior #83
+377
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the test case to reflect current behavior where workers no longer quit on replication errors. With Spock 5.0, subscriptions are now disabled when exception_behaviour = 'SUB_DISABLE'. Also added a helper function to the init script to simplify setup of test scenarios.
rasifr
force-pushed
the
SPOC-82-add-primary_key-regression-tests
branch
from
3a7400f to
a60a4c4
Compare
mason-sharp
approved these changes
Jul 14, 2025
|
The codacy complaints are for the regression test sql files that run fine and can be ignored. Will look into configuring to ignore those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the test case to reflect current behavior where workers no longer quit on replication errors. With Spock 5.0, subscriptions are now disabled when exception_behaviour = 'SUB_DISABLE'.
Also added a helper function to the init script to simplify setup of test scenarios.