json-create supports hostnames node config #350
Merged
+12
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2025 12:21
json-create allows creation of a node or subnode with either ip address or hostname through the use of socket.gethostbyname PLAT-131
In the case that a hostname or ip address cannot be resolved by gethostbyname, socket error will be caught, appended to validation_errors and reported with the specific node from which it arose from. PLAT-131
GabriellePoncey
changed the title
GabriellePoncey
changed the title
mmols
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json-create allows creation of a node or subnode with either ip address or hostname through the use of socket.gethostbyname
PLAT-131