Add README with basic troubleshooting tips to the Blinky example#304
Open
rogerdahl wants to merge 2 commits intopfalcon:masterfrom
Open
Add README with basic troubleshooting tips to the Blinky example#304rogerdahl wants to merge 2 commits intopfalcon:masterfrom
rogerdahl wants to merge 2 commits intopfalcon:masterfrom
Conversation
Owner
|
Thanks for the patch! But there're 2 issues even on the surface: contributed files uses overlong lines, which makes them not readable and not maintainable, and the fact that there're files, instead there should be one file and one commit for it. Beyond that, there're deeper issues. This would be about one millionth "basic troubleshooting tips for esp8266" on interwebs. All incomplete, some confusing. For example, what Mac users will do with/about "sudo usermod -a -G dialout `"? esp-open-sdk's approach has always been simple: it's a script to build a toolchain. Most other parts are handled by other sites/projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.