Skip to content

Add some dark theme tweaks and small html fix #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add some dark theme tweaks and small html fix #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
693fba6
added support for dark themes for matchs & groups
mackenza Sep 24, 2014
0c535d5
added display: inline to avoid orphaned style tag
mackenza Sep 24, 2014
e8353f5
lock overlay to fixed font size
mackenza Sep 25, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ define(function (require, exports, module) {
groups += "<span class='regex-group-match unmatched-group' data-groupnum='" + i + "'><strong>$" + i + "</strong></span>";
}
}
this.$htmlContent.find(".inline-regex-groups").html(groups).show();
this.$htmlContent.find(".inline-regex-groups").html(groups).css("display", "inline").show();
} else {
this.$htmlContent.find(".inline-regex-groups").hide();
}
Expand Down
15 changes: 13 additions & 2 deletions regex-editor-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@

.inline-regex-editor .inline-regex-sample {
font-family: "SourceCodePro";
font-size: inherit;
font-size: 12px;
padding: 2px 2px 2px 6px; /* 6px aligns L edge of text with CM field above */
}

Expand All @@ -75,6 +75,10 @@
color: #000090
}

.dark .inline-regex-editor .inline-regex-match {
color: #33ccff;
}

.inline-regex-editor .inline-regex-groups {
margin-left: 5px;
background-color: #d3d3ff;
Expand All @@ -84,6 +88,10 @@
font-size: inherit;
color: #000090;
}
.dark .inline-regex-editor .inline-regex-groups {
background-color: #000033;
color: #33ccff;
}
.inline-regex-editor .inline-regex-groups .regex-group-match {
padding: 0 5px;
}
Expand All @@ -93,6 +101,9 @@
.inline-regex-editor .inline-regex-groups .regex-group-match:hover {
background-color: #9f9ff5;
}
.dark .inline-regex-editor .inline-regex-groups .regex-group-match:hover {
background-color: #000066;
}
.inline-regex-editor .inline-regex-groups .regex-group-match strong {
font-weight: bold;
}
Expand All @@ -112,4 +123,4 @@

/* top is programmatically set to match top of .inline-regex-sample; adjust downward to match its border + padding */
margin-top: 3px;
}
}