fix: reset the snapshot counter between flaky retries - #1872
Closed
lazerg wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Thanks! Already covered by b8c2265 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
SnapshotRepository::$expectationsCounteris static and keyed by test file plus description, so severaltoMatchSnapshot()calls in one test resolve to.snap,__2.snap, and so on.Testable::__runTest()replays the closure in the same process on a flaky retry and never clears that key, so attempt 2 looks for__2.snap. It does not exist, gets created from the current value, and the test ends as incomplete on a green suite. Every run after that passes, because attempt 1 still fails against the real baseline and attempt 2 matches the file the first run wrote. On CI the run fails, but it names a__3.snapnobody created instead of the value that actually drifted.The retry already restores object properties, mock objects and the output buffer before running again. The counter belongs to that cleanup, so it is reset there too, and the retried attempt resolves the same snapshot file as the first one.
Related:
Fixes #1871