Skip to content

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented May 17, 2024

Both approaches look pretty ugly, ideas?

image

image

Fix #2434

@fflaten
Copy link
Collaborator

fflaten commented May 18, 2024

I personally prefer tests before time.
Any of these less ugly?
image
image

@@ -728,7 +728,7 @@ function Get-WriteScreenPlugin ($Verbosity) {
throw "Unsupported level of output '$($PesterPreference.Output.Verbosity.Value)'"
}

$humanTime = "$(Get-HumanTime ($_test.Duration)) ($(Get-HumanTime $_test.UserDuration)|$(Get-HumanTime $_test.FrameworkDuration))"
$humanTime = Get-HumanTime $_test.Duration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also affects Detailed++. Intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional, but will revert.

@nohwnd
Copy link
Member Author

nohwnd commented May 18, 2024

Good idea with (). How about tests.ps1 55 tests (22ms)?

@fflaten
Copy link
Collaborator

fflaten commented May 18, 2024

I'd prefer parentheses on the first element as it helps separate filename from details at a glance, especially without colored output (plaintext/colorblind/etc)

Don't have a strong opinion on whether it should contain testcount or duration. I guessed you felt tests made it messy which is why I opted for count above 🙂

@nohwnd
Copy link
Member Author

nohwnd commented Jan 9, 2025

/backport to rel/5.x.x

Copy link

github-actions bot commented Jan 9, 2025

Started backporting to rel/5.x.x: https://github.com/pester/Pester/actions/runs/12698516948

@nohwnd
Copy link
Member Author

nohwnd commented Jan 9, 2025

/backport to rel/5.x.x

Copy link

github-actions bot commented Jan 9, 2025

Started backporting to rel/5.x.x: https://github.com/pester/Pester/actions/runs/12698540492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test count to minimal view
2 participants