Use lookupYAMLNode to safely check empty config nodes. #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where namespace entries need to have a spurious blank name entry because leaving them empty makes them null.
jslee02
approved these changes
Apr 15, 2020
| // Return if failed to find a tag of 'key' | ||
| if (not next) | ||
| // Return if failed to find a tag of 'key'. | ||
| if (!next) |
There was a problem hiding this comment.
For future reference, we don't prefer using not for consistency?
There was a problem hiding this comment.
Yes, the not, and, bitand, etc. text versions of the operators are in the c++ spec, but they are not commonly used and IIRC require permissive flags on some compilers like MSVC. So I don't really see a good reason to start using them here.
|
I am not yet sure if this works, waiting to see the unit tests run 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug where namespace entries need to have a spurious blank name entry because leaving them empty makes them null.