configure.ac: fix TEXI2DVI check to handle missing program case#52
Open
Zetsyog wants to merge 1 commit intoperiscop:masterfrom
Open
configure.ac: fix TEXI2DVI check to handle missing program case#52Zetsyog wants to merge 1 commit intoperiscop:masterfrom
Zetsyog wants to merge 1 commit intoperiscop:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AC_CHECK_PROGmacro is misused.The third argument specifies the default value to assign if the program provided as the second argument is not found. However, the line
AM_CONDITIONAL(HAVE_TEXI2DVI, test -n "$TEXI2DVI")incorrectly checks whether the variable$TEXI2DVIis empty, which never occurs.As a result, documentation is always attempted to be built, even if
texi2dviis not installed, causing compilation errors.This issue is resolved by assigning an empty string as the third argument.