Fix false positive for subscript(dynamicMember:) in external type extensions#1067
Open
rnapier wants to merge 1 commit intoperipheryapp:masterfrom
Open
Fix false positive for subscript(dynamicMember:) in external type extensions#1067rnapier wants to merge 1 commit intoperipheryapp:masterfrom
rnapier wants to merge 1 commit intoperipheryapp:masterfrom
Conversation
…ensions Periphery incorrectly reported subscript(dynamicMember:) as unused when declared in an extension of an external type with @dynamicMemberLookup (e.g., Foundation's AttributeDynamicLookup). The fix retains all subscript(dynamicMember:) declarations unconditionally, since this signature is specific to Swift's @dynamicMemberLookup mechanism. Fixes peripheryapp#1066
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Periphery incorrectly reported subscript(dynamicMember:) as unused when declared in an extension of an external type with @dynamicMemberLookup (e.g., Foundation's AttributeDynamicLookup).
The fix retains all subscript(dynamicMember:) declarations unconditionally, since this signature is specific to Swift's @dynamicMemberLookup mechanism.
Fixes #1066