K8SPXC-735: ProxySQL scheduler improvements #2281
Open
+218
−2,199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes various improvements for scheduler implementation: 1. Cleaning up zombie processes created by percona-scheduler-admin in pxc-monit container. 2. Running zombie reaper in proxysql container only when scheduler is enabled. 3. Running percona-scheduler-admin with `--force` to overcome unique constraint failures.
egegunes
requested review from
eleo007,
gkech,
hors,
jvpasinatto,
nmarukovich,
pooknull and
valmiranogueira
as code owners
hors
requested changes
Dec 2, 2025
pkg/pxc/app/statefulset/proxysql.go
Outdated
| }, | ||
| }...) | ||
|
|
||
| pxcMonit.Command = []string{"/opt/percona/proxysql_peer_list_entrypoint.sh"} |
Collaborator
There was a problem hiding this comment.
@egegunes the problem is that you changed entrypoint and now the operator can't update
/etc/proxysql-admin.cnf and the container just use default one e.g. with default passwords
egegunes
requested review from
bogdanjeler-ev,
mayankshah1607 and
oksana-grishchenko
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+133
to
+135
| sleep 0.5 | ||
| # Reap any zombie processes that are children of PID 1 | ||
| while wait -n 2>/dev/null; do :; done |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| sleep 0.5 | |
| # Reap any zombie processes that are children of PID 1 | |
| while wait -n 2>/dev/null; do :; done | |
| sleep 0.5 | |
| # Reap any zombie processes that are children of PID 1 | |
| while wait -n 2>/dev/null; do :; done |
| # Forward signals to main process | ||
| forward_signal() { | ||
| kill -"$1" "$PROXYSQL_PID" 2>/dev/null || true | ||
| kill -"$1" "$MAIN_PID" 2>/dev/null || true |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| kill -"$1" "$MAIN_PID" 2>/dev/null || true | |
| kill -"$1" "$MAIN_PID" 2>/dev/null || true |
Collaborator
commit: 3aa4f94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
This commit includes various improvements for scheduler implementation:
--forceto overcome unique constraint failures.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability