-
Notifications
You must be signed in to change notification settings - Fork 203
K8SPXC-1576: xtrabackup support poc #2274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
| } | ||
|
|
||
| switch cfg.Type { | ||
| case BackupStorageType_GCS: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about PVC backup? Will we support this type? In PXCO we have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I'm not sure we can support it. With SST, backup occurs on the job pod, so we create new PVC and mount it on the job and take backup there.
But now the architecture is different - the backup process occurs alongside pxc in a sidecar. So we cannot dynamically mount/unmount new PVC like we do in sst with a job. I'm not sure how we can implement PVC backups, we need to think about it maybe as a separate task. Maybe we can consider using VolumeSnapshots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, we can do it via separate PR (not now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more trick I think we can try - since xtrabackup allows you to output a tar stream, we can stream that data from stdout to a grpc channel on another job. Then similar to our current approach, the job will mount the PVC and rebuild the backup data from the tar received over the stream.
To maintain consistency with s3 and azure, the job can similarly read xbstream from the grpc channel and run xbcloud there.
I think it is possible. Maybe we can use that approach in PS operator as well. Anyway, let's tackle it in a separate task.
Signed-off-by: Mayank Shah <[email protected]>
commit: 91588dd |
CHANGE DESCRIPTION
Support for backups using
xtrabackup.To enable this feature, set
PXCO_FEATURE_GATES=BackupXtrabackupin the operator deployment.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability