K8SPG-768 skip log creation #1217
Open
+669
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarukovich
requested review from
hors,
egegunes,
pooknull and
gkech
as code owners
… into K8SPG-768_skip_log_creation
gkech
reviewed
Jul 14, 2025
Comment on lines
-236
to
-250
|
|
||
| # Manage autogrow annotation. | ||
| # Return size in Mebibytes. | ||
| size=$(df --human-readable --block-size=M /pgdata | awk 'FNR == 2 {print $2}') | ||
| use=$(df --human-readable /pgdata | awk 'FNR == 2 {print $5}') | ||
| sizeInt="${size//M/}" | ||
| # Use the sed punctuation class, because the shell will not accept the percent sign in an expansion. | ||
| useInt=$(echo $use | sed 's/[[:punct:]]//g') | ||
| triggerExpansion="$((useInt > 75))" | ||
| if [ $triggerExpansion -eq 1 ]; then | ||
| newSize="$(((sizeInt / 2)+sizeInt))" | ||
| newSizeMi="${newSize}Mi" | ||
| d='[{"op": "add", "path": "/metadata/annotations/suggested-pgdata-pvc-size", "value": "'"$newSizeMi"'"}]' | ||
| curl --cacert ${CACERT} --header "Authorization: Bearer ${TOKEN}" -XPATCH "${APISERVER}/api/v1/namespaces/${NAMESPACE}/pods/${HOSTNAME}?fieldManager=kubectl-annotate" -H "Content-Type: application/json-patch+json" --data "$d" | ||
| fi |
There was a problem hiding this comment.
I think it would be nice to add a unit test with the FG enabled so that we can assert that is part exists in the script. WDYT?
There was a problem hiding this comment.
Yep, I think it's a good point. I will fix it.
…ona-postgresql-operator into K8SPG-768_skip_log_creation
gkech
reviewed
Jul 15, 2025
internal/postgres/config.go
Outdated
| @@ -170,7 +170,7 @@ func Environment(cluster *v1beta1.PostgresCluster) []corev1.EnvVar { | |||
| // reloadCommand returns an entrypoint that convinces PostgreSQL to reload | |||
| // certificate files when they change. The process will appear as name in `ps` | |||
| // and `top`. | |||
| func reloadCommand(name string, post250 bool) []string { | |||
| func reloadCommand(name string, post250 bool, AutoGrowVolumes bool) []string { | |||
There was a problem hiding this comment.
I think we need to introduce a version check for changing the script in this function given that it is triggered here:
reloader := corev1.Container{
Name: naming.ContainerClientCertCopy,
Command: reloadCommand(naming.ContainerClientCertCopy, inCluster.CompareVersion("2.5.0") >= 0, feature.Enabled(ctx, feature.AutoGrowVolumes)),
Image: container.Image,
ImagePullPolicy: container.ImagePullPolicy,
SecurityContext: initialize.RestrictedSecurityContext(inCluster.CompareVersion("2.5.0") >= 0),
VolumeMounts: []corev1.VolumeMount{certVolumeMount},
}
You can verify that by checking the failures on the upgrade-minor e2e test
egegunes
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Excessive log generation from the replication-cert-copy container within the Postgres database pod. The container checks available disk space, and if the free volume is less than 75%, it triggers a Kubernetes API call to update the pod annotation with a suggested volume size (e.g., suggested-pgdata-pvc-size: 15345Mi).
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Avoid updating the pod annotation unless AutoGrowVolumes is enabled.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability