-
Notifications
You must be signed in to change notification settings - Fork 64
K8SPG-777 set crVersion #1210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
K8SPG-777 set crVersion #1210
Conversation
@@ -7,6 +7,7 @@ import ( | |||
"fmt" | |||
"io" | |||
"reflect" | |||
logf "sigs.k8s.io/controller-runtime/pkg/log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[goimports-reviser] reported by reviewdog 🐶
logf "sigs.k8s.io/controller-runtime/pkg/log" |
@@ -5941,6 +5941,9 @@ spec: | |||
Version of the operator. Update this to new version after operator | |||
upgrade to apply changes to Kubernetes objects. Default is the latest | |||
version. | |||
enum: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I use 2.6.0 with this CRD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it was like en example.
how can we make it better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
commit: 0b8a9b0 |
CHANGE DESCRIPTION
Problem:
Add validation for crVersion and ensure it is set if empty.
Since crVersion is defined as a string, we must store it as a string value to avoid validation errors.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability