Add per-profile default keymaps support#14
Merged
peppapighs merged 1 commit intopeppapighs:devfrom Jan 13, 2026
Merged
Conversation
peppapighs
force-pushed
the
profile-json-defining
branch
from
64942da to
e680db9
Compare
peppapighs
requested changes
Jan 10, 2026
Owner
peppapighs
left a comment
peppapighs
left a comment
There was a problem hiding this comment.
Thanks for the PR. I left some comments in the code. Please let me know if you have any thoughts about them. I will prepare the changes on the hmkconf side.
Contributor
Author
|
Thanks for the comments! I will implement the changes today:) |
yiancar
force-pushed
the
profile-json-defining
branch
from
e680db9 to
51807e9
Compare
Contributor
Author
|
@peppapighs please let me know what you think:) |
peppapighs
force-pushed
the
profile-json-defining
branch
from
c8854bb to
00fef4a
Compare
Owner
|
I readded your validation and fallback logic for the default keymaps. Everything looks good now. I will merge this change. Thanks again for the help! |
peppapighs
force-pushed
the
profile-json-defining
branch
from
00fef4a to
5913f2f
Compare
peppapighs
force-pushed
the
profile-json-defining
branch
from
5913f2f to
30e9f82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently by default all profiles match the default keymap.
Added the optional profile_keymaps array to the schema.
This is an array of keymaps, one per profile. Any empty profiles default to the default keymap.