[BISERVER-15769] - remove unused finalizer - #6348
Merged
Merged
Conversation
Was a no-op and caused the objects to stay in memory waiting for finalization
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
OSS Licenses | 0 0 0 0 |
View in Orca |
| Passed |
Malicious Packages | 0 0 0 0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change removes a no-op finalizer without affecting runtime behavior and reduces GC/finalization overhead risk.
Pull request overview
Removes an unused finalize() override from the JCR session proxy invocation handler in CredentialsStrategySessionFactory, eliminating finalizable-object behavior that can delay garbage collection and keep instances in memory longer than necessary.
Changes:
- Deleted a no-op
finalize()method from the innerLogoutSuppressingInvocationHandlerclass to avoid unnecessary finalization overhead/retention.
File summaries
| File | Description |
|---|---|
| repository/src/main/java/org/pentaho/platform/repository2/unified/jcr/sejcr/CredentialsStrategySessionFactory.java | Removes an unused finalizer from the session invocation handler to prevent finalization-induced retention. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Collaborator
✅ Build finished in 6m 49sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl repository👌 All tests passed! Tests run: 626, Failures: 0, Skipped: 0 Test Results ℹ️ This is an automatic message |
|
0 New Issues
3 Fixed Issues
0 Accepted Issues
No data about coverage (22.70% Estimated after merge)
tgf
approved these changes
Sep 3, 2026
befc
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was a no-op and caused the objects to stay in memory waiting for finalization