-
-
Notifications
You must be signed in to change notification settings - Fork 123
Improve unsubscribe link to prevent accidental unsubscribes #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
wmnnd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great initiative taking on this issue! I've left some comments that need to be addressed before I can merge this 😊
|
Upon further reading on this, I think we can just rely on a normal POST, without needing JavaScript. The main issue is anti-spam software hitting links in emails to check them. But they shouldn't POST, so we should be fine with a normal form. |
…implify form handling
|
Pushed some changes. I'm not sure of the process for updating translations correctly. Some guidance on that would help. |
|
On the translations note, it appears that if I run If I run |
Fixes #348