Skip to content

Conversation

@andreialecu
Copy link

Fixes #348

Copy link
Contributor

@wmnnd wmnnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative taking on this issue! I've left some comments that need to be addressed before I can merge this 😊

@andreialecu
Copy link
Author

Upon further reading on this, I think we can just rely on a normal POST, without needing JavaScript.

The main issue is anti-spam software hitting links in emails to check them. But they shouldn't POST, so we should be fine with a normal form.

@andreialecu
Copy link
Author

Pushed some changes. I'm not sure of the process for updating translations correctly. Some guidance on that would help.

@andreialecu
Copy link
Author

On the translations note, it appears that if I run mix gettext.extract --merge a bunch of messages get removed. They're related to files in the extra directory.

If I run WITH_EXTRA=1 mix gettext.extract --merge instead, I get:

== Compilation error in file extra/keila/license/license.ex ==
** (FunctionClauseError) no function clause matching in :public_key.der_decode/2    
    
    The following arguments were given to :public_key.der_decode/2:
    
        # 1
        :EcpkParameters
    
        # 2
        :asn1_NOVALUE
    
    (public_key 1.14) public_key.erl:332: :public_key.der_decode/2
    (public_key 1.14) public_key.erl:225: :public_key.pem_entry_decode/1
    extra/keila/license/license.ex:18: (module)
    (elixir 1.15.1) lib/kernel/parallel_compiler.ex:377: anonymous fn/5 in Kernel.ParallelCompiler.spawn_workers/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Confirmation to Unsubscribe Page for Short Time After Sending Campaign

2 participants