Skip to content

Conversation

bith3ad
Copy link
Contributor

@bith3ad bith3ad commented Apr 8, 2025

Platsch always uses the static libraries (see meson.build).

Drop the deprecated static compilation comment here to not confuse the users.

Platsch always uses the static libraries (see meson.build).

Drop the deprecated static compilation comment here to not confuse the
users.

Signed-off-by: Marco Felsch <[email protected]>
Copy link
Member

@ejoerns ejoerns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bith3ad bith3ad merged commit 2528301 into main Apr 9, 2025
2 checks passed
@bith3ad bith3ad deleted the mfe/README-fixup branch April 9, 2025 18:31
@michaelolbrich
Copy link
Member

Hmmm, I'm a bit late, but -Dprefer_static=true is not redundant: meson.build only ensures, that libplatsch is linked statically, but libdrm and libc are still linked dynamically.

With -Dprefer_static=true libdrm at least is linked statically as well, at least in my test. I'm not sure why libc was still linked dynamically, probably because no matching static library was found, or something like that.

@bith3ad
Copy link
Contributor Author

bith3ad commented Apr 10, 2025

You're right, I can confirm this and now start to remember, sorry. I will revert this commit and extend the comment in the README, that libplatsch is always linked statically but the other may not e.g. only of the the switch was provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants