add zero_prefixed_house_numbers script #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
force-pushed
the
zero_prefixed_house_numbers
branch
from
8682e2a to
d89b9b6
Compare
Member
Author
|
It appears that this functionality was already added to the OpenAddresses importer but only applies to ordinal numbers: |
missinglink
force-pushed
the
zero_prefixed_house_numbers
branch
from
d89b9b6 to
3a71c2d
Compare
Member
Author
|
Member
Author
|
Zero prefixed house number post-processing script strips leading zeros from house numbers. eg. house number `001` -> `1`.
missinglink
force-pushed
the
zero_prefixed_house_numbers
branch
from
3a71c2d to
396e8e0
Compare
Member
|
I don't think housenumbers starting with zero are common in the US, and checking on the Idaho addresses shown above, they don't seem to be commonly written with a leading zero. The leading zero in Berlin could be different. Do you think leading zero housenumbers are common anywhere? I'm leaning towards no. |
Member
Author
I also thought not, but when I checked the data they are in fact fairly common. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in pelias/schema#503