Skip to content

Improve Local::has_translations #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve Local::has_translations #461

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75abff2
Improve Local::has_translations
szepeviktor May 22, 2024
8f8619b
Increase strictness
szepeviktor May 22, 2024
673959f
Hi Yoda!
szepeviktor May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions includes/class-locale.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class Locale extends GP_Locale {
/**
* Array of available translations data obtained with wp_get_available_translations() for the locale.
*
* @var array
* @var array|null
*/
public $translations;

Expand Down Expand Up @@ -78,11 +78,7 @@ public function __construct( $locale ) {
*/
public function has_translations() {

if ( is_null( $this->translations ) ) {
return false;
} else {
return true;
}
return is_array( $this->translations ) && array() !== $this->translations;
}
}

Expand Down