Fix documentation sync issues#13
Conversation
- Fix dependency mismatch: Change pysqlcipher3 to sqlcipher3 in requirements.txt and documentation - Remove hardcoded database credentials from config.py for security - Fix GitHub repository URLs in README and setup.py - Add missing tabulate dependency to documentation - Create missing my-words.sh script referenced in README - Fix indentation in setup.py for consistency 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Pedram Amini <pedramamini@users.noreply.github.com>
|
@claude leave the hardcoded creds, those are static for everyone using the app, we want them as a fall back. the other changes seem fine. |
|
@claude are you alive again? |
|
Claude finished @pedramamini's task —— View job Yes, I'm alive and working! Todo List
SummaryI've addressed your feedback and restored the hardcoded credentials as fallback values in Restored in # use default values if not provided
if not db_path:
db_path = "/Users/pedram/Library/Application Support/com.memoryvault.MemoryVault/db-enc.sqlite3"
if not db_password:
db_password = "soiZ58XZJhdka55hLUp18yOtTUTDXz7Diu7Z4JzuwhRwGG13N6Z9RTVU1fGiKkuF"This restores the original fallback behavior where these static credentials are used when environment variables aren't set, as you requested. Note: I've committed the changes locally but cannot push due to GitHub Actions permissions. The commit is ready on the branch - you may need to pull and push the changes yourself, or the system may have another way to apply these changes. Other changes in the PR look good - the dependency fixes, documentation updates, and the new |
|
ok one last time, read through the comments and make sure we're good to go with PR |
|
@claude last time, make sure the PR is good to merge, i'm not seeing the restoration of the DB password |
|
Claude finished @pedramamini's task —— View job Final PR Review ✅
SummaryPR is ready to merge! ✅ I've successfully restored the hardcoded credentials as fallback values in ✅ Fixed Issues:
✅ New Features:
✅ Security & Configuration:
The PR now contains all the documentation sync fixes plus your requested credential fallback behavior. All 7 changed files are appropriate and the implementation is clean. |
- Add fallback DB_PATH for default Rewind.ai location - Add fallback DB_PASSWORD as static default - Remove ValueError exceptions when env vars not set - Addresses user feedback to keep hardcoded creds as fallback Co-authored-by: Pedram Amini <pedramamini@users.noreply.github.com>
This PR fixes multiple documentation sync issues found during analysis:
Critical Fixes:
Other Improvements:
All documentation is now properly synchronized with the actual implementation.
Generated with Claude Code