Skip to content

CAT-24924 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

CAT-24924 #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d3cdf4
CAT-24924 Added ecs:executecommand permission and ssm param retrieval…
ehirsch-3pg Apr 16, 2025
6f63877
Running document script
ehirsch-3pg Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
### Using the Repo Source

```hcl
github.com/pbs/terraform-aws-ecs-task-definition-module?ref=2.1.2
github.com/pbs/terraform-aws-ecs-task-definition-module?ref=x.y.z
```

### Alternative Installation Methods
Expand All @@ -22,7 +22,7 @@ Integrate this module like so:

```hcl
module "task" {
source = "github.com/pbs/terraform-aws-ecs-task-definition-module?ref=2.1.2"
source = "github.com/pbs/terraform-aws-ecs-task-definition-module?ref=x.y.z"

# Tagging Parameters
organization = var.organization
Expand All @@ -40,7 +40,7 @@ module "task" {

If this repo is added as a subtree, then the version of the module should be close to the version shown here:

`2.1.2`
`x.y.z`

Note, however that subtrees can be altered as desired within repositories.

Expand Down
13 changes: 13 additions & 0 deletions security.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ data "aws_iam_policy_document" "policy_doc" {
"cloudwatch:PutMetricData",
"kms:ListKeys",
"ssm:DescribeParameters",
"ecs:ExecuteCommand",
]
resources = ["*"]
}
Expand Down Expand Up @@ -140,6 +141,18 @@ data "aws_iam_policy_document" "task_execution_role_policy_doc" {
resources = ["*"]
}

statement {
actions = [
"kms:Decrypt",
"ssm:GetParametersByPath",
"ssm:GetParameters",
"ssm:GetParameter"
]
resources = [
"arn:aws:ssm:${data.aws_region.current.name}:${data.aws_caller_identity.current.account_id}:parameter${local.ssm_path}*",
]
}

dynamic "statement" {
for_each = local.use_newrelic_firelens_sidecar ? [local.newrelic_secret_arn] : []
content {
Expand Down