fix(react-paypal-js): keep latest message fetch state - #1050
Open
OskarEichler wants to merge 3 commits into
Open
OskarEichler wants to merge 3 commits into
OskarEichler wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 883ea89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| await firstFetch; | ||
| }); | ||
|
|
||
| expect(result.current.error).toBeNull(); |
Contributor
There was a problem hiding this comment.
Similar to my comment on PR 1051, can we also assert that the content is the populatedContent?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
usePayPalMessagescan retain a failed fetch error after a later fetch succeeds. Concurrent fetches can also complete out of order, allowing an older empty-content response to overwrite the state of a newer successful request. A request finishing after its session changes can update the current hook for an obsolete session.Fix
No public API, returned content, or dependency changes are introduced.
Verification
git diff --checkpass.