fix(react-paypal-js): compare own keys when memoizing eligibility payloads - #1043
Open
OskarEichler wants to merge 3 commits into
Open
OskarEichler wants to merge 3 commits into
OskarEichler wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 70f7e5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Can you add tests that demonstrate the issue this is fixing 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Require each compared object key to be an own property of the other object before recursively comparing its value. Equal key counts and equal property lookups alone do not establish equality: {a: undefined} and {b: undefined} previously compared equal, as could an inherited property standing in for a missing own key.
This prevents deep-comparison memoization from reusing a different eligibility payload. Existing reference, array, depth-limit and value comparison behavior is preserved; no new dependency or public API.
Verification
Inline reproductions confirm both distinct-undefined-key and inherited-key false positives change from true to false. Combined reviewed patch set: existing React suite has 914 passes, 2 pre-existing HostedFieldsProvider failures and 17 passing snapshots, identical to unmodified main. Lint/typecheck, Rollup builds, declarations and diff/format checks pass (five existing JSDoc warnings). No test files changed.