fix(react-paypal-js): preserve Braintree options and clean up checkout instances - #1041
Open
OskarEichler wants to merge 2 commits into
Open
OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 09ec145 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Compatibility
No public API/type changes. Shipping options already accepted by the button types now reach the SDK. Incomplete legacy namespaces fail early with the existing descriptive error. No new payment/capture behavior or client-instance ownership changes.
Verification
React 19/JSDOM mocked-SDK reproductions cover unmount during checkout creation, unmount during SDK load, normal unmount and SDK-load failure: each instance closes once (previously three of these leaked). Button-to-session option capture confirms restored shipping props, with billing-agreement behavior unchanged. Both partially populated legacy namespaces are rejected.
Combined reviewed patch set: existing React suite has 914 passes, 2 pre-existing HostedFieldsProvider failures and 17 passing snapshots, identical to unmodified main. Lint/typecheck, Rollup builds, declarations and diff/format checks pass (five existing JSDoc warnings). No live Braintree/PayPal transactions. No test files changed.