fix(react-paypal-js): release v6 payment sessions exactly once - #1040
Open
OskarEichler wants to merge 2 commits into
Open
OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 2f13c58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Clear the owned session before destroying it, and let effect cleanup destroy only the session it still owns. Apply the same correction to PayPal one-time/save/subscription/guest, PayPal Credit one-time/save, Venmo and Pay Later hooks.
Previously, calling handleDestroy followed by unmount called destroy twice. SDK replacement/removal also left the ref pointing to an already-destroyed session, allowing a later handleClick to start it.
Compatibility
No public API/type changes. Destroy is now idempotent for the owned session; calls after disposal follow the existing unavailable-session error path instead of invoking a destroyed SDK object.
Verification
React 19/JSDOM mocked-SDK reproductions for all eight hooks: manual destroy plus unmount changes from two destroy calls to one; SDK removal followed by click changes from one stale start to zero. Combined reviewed patch set: existing React suite has 914 passes, 2 pre-existing HostedFieldsProvider failures and 17 passing snapshots, identical to unmodified main. Lint/typecheck, Rollup builds, declarations and diff/format checks pass (five existing JSDoc warnings). No live transactions. No test files changed.