-
Notifications
You must be signed in to change notification settings - Fork 76
Unused dependency flaged by nix check #1222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
drop the .udl match from the cleanSourceWith filter as Uniffi does not use .udl files anymore
enforces unused dependency detection in nix flake check
Pull Request Test Coverage Report for Build 20144561401Details
💛 - Coveralls |
| uniffi = { version = "0.30.0" } | ||
| url = "2.5.4" | ||
|
|
||
| [package.metadata.cargo-machete] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain why this is necessary here instead of a removal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I kept getrandom because the wasm_js feature requires getrandom/js so it’s an actual dependency.
If you remove it and run cargo check you’ll see this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this exclusion should be explained in a code comment here
payjoin-ffi/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| base64 = "0.22.1" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra line
spacebear21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I have some very minor comments but otherwise lgtm
Dropped unused dependency flagged by cargo machete across codebase. Kept getrandom because the wasm_js feature requires getrandom/js and marked it ignored in machete metadata
933bded to
fe4858c
Compare
benalleng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack fe4858c
This PR addresses the following changes:
Note: I kept getrandom because the wasm_js feature requires getrandom/js so it’s an actual dependency.
If you remove it and run
cargo checkyou’ll see this.After adding machete check I ran
nix flake checkwhich displayed the log belowSecond time running after removing dependencies I got the error below. It did not catch this in the first check :
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.