Nixos stable 25.11 #1210
Merged
Nixos stable 25.11 #1210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 20034221122Details
💛 - Coveralls |
benalleng
force-pushed
the
nixos-stable-25.11
branch
from
a7be512 to
c05494f
Compare
nothingmuch
approved these changes
Dec 3, 2025
Collaborator
nothingmuch
left a comment
nothingmuch
left a comment
There was a problem hiding this comment.
utACK, but i would appreciate one comment on the line i don't understand and someone else should also review since i had a hand in some of the changes here
Collaborator
|
Collaborator
|
Cool, I can give this a review tomorrow |
benalleng
force-pushed
the
nixos-stable-25.11
branch
3 times, most recently
from
402d717 to
596cfb1
Compare
Collaborator
Author
|
I found that we can actually get rid of this build check ignore here NixOS/nixpkgs#468002 going to label this as blocked until that is merged in. |
benalleng
force-pushed
the
nixos-stable-25.11
branch
from
596cfb1 to
60c5601
Compare
benalleng
force-pushed
the
nixos-stable-25.11
branch
from
60c5601 to
d878794
Compare
Collaborator
Author
|
The update to nixos-25.11 has had the cargo-llvm-cov update backported in so we now no longer need the workaround, see the build success in nixos-25.11 release https://hydra.nixos.org/build/315952046 |
nothingmuch
approved these changes
Dec 8, 2025
Collaborator
nothingmuch
left a comment
nothingmuch
left a comment
There was a problem hiding this comment.
ACK, tested on linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also supercedes #1022 as there were a lot of changes I would need to duplicate here to do proper flake checks
I was having a hard time getting cargo-llvm-cov to compile and pass tests so I skipped the tests in 49c82d7
passed
nix flake checkPull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.