Switch dart bindings to use native assets #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 19910130353Details
💛 - Coveralls |
spacebear21
force-pushed
the
ffi-dart-native-assets
branch
2 times, most recently
from
8abfcec to
be117a8
Compare
spacebear21
force-pushed
the
ffi-dart-native-assets
branch
5 times, most recently
from
ee4e79d to
5a49eb5
Compare
Collaborator
Author
|
@benalleng looks like the cargo-mutants Diff CI job is failing due to a modification to |
spacebear21
force-pushed
the
ffi-dart-native-assets
branch
2 times, most recently
from
59dc734 to
3592336
Compare
2 tasks
This changes the bitcoin-ffi revision accordingly to one that supports 0.30.
spacebear21
force-pushed
the
ffi-dart-native-assets
branch
from
3592336 to
1a87042
Compare
With the changes from Uniffi-Dart/uniffi-dart#99, the native libraries can be compiled automagically in a dart build hook.
uniffi::generate_scaffolding! is only necessary when using UDL (https://mozilla.github.io/uniffi-rs/latest/tutorial/Rust_scaffolding.html). We use proc macros so we can skip build.rs entirely!
spacebear21
force-pushed
the
ffi-dart-native-assets
branch
from
1a87042 to
52a4538
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes from Uniffi-Dart/uniffi-dart#99, the native libraries can be compiled automagically in a dart build hook, a feature added very recently in Dart 3.10 which solves a lot of packaging headaches.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.