Skip to content

Conversation

@benalleng
Copy link
Collaborator

@benalleng benalleng commented Oct 24, 2025

This relates to #1177 but I think it should remain open until we can determine why uv is doing this and revert our runner to not having any special OS clauses

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls
Copy link
Collaborator

coveralls commented Oct 24, 2025

Pull Request Test Coverage Report for Build 18787732215

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.698%

Totals Coverage Status
Change from base Build 18783991185: 0.0%
Covered Lines: 8990
Relevant Lines: 10741

💛 - Coveralls

@benalleng benalleng force-pushed the force-pip-version branch 7 times, most recently from dd250c3 to ee827e9 Compare October 24, 2025 15:55
@benalleng benalleng requested a review from spacebear21 October 24, 2025 15:59
@benalleng
Copy link
Collaborator Author

Here is the action outcome before removing the payjoin-ffi/README.md CI forcing change. https://github.com/payjoin/rust-payjoin/actions/runs/18785098425

Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not use the same python version on ubuntu and macos runners?

@benalleng

This comment was marked as resolved.

@benalleng benalleng force-pushed the force-pip-version branch 8 times, most recently from 319eb3d to e2ef933 Compare October 24, 2025 17:43
The macos-15 defaults to python3.13 and the Ubuntu runner defaults to
python3.12. I opted to just force both of them to use the latest
python3.14 for both runners as the `uv` command seemed to be incorrectly
trying to use the rong wheel version.
Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@benalleng benalleng merged commit 4b504f4 into payjoin:master Oct 24, 2025
19 of 20 checks passed
@benalleng benalleng deleted the force-pip-version branch October 24, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants