Skip to content

Conversation

@arminsabouri
Copy link
Collaborator

Related ticket: #1143

Pull Request Checklist

Please confirm the following before requesting review:

Ai disclosure: use cursor to group relevant Prs together in the change log.

@arminsabouri
Copy link
Collaborator Author

Blocked by #1141

@arminsabouri arminsabouri force-pushed the bump-payjoin-1-0-0-rc-0 branch from 0c05a38 to c32fddd Compare October 3, 2025 17:37
@coveralls
Copy link
Collaborator

coveralls commented Oct 3, 2025

Pull Request Test Coverage Report for Build 18233490444

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.21%

Totals Coverage Status
Change from base Build 18233448897: 0.0%
Covered Lines: 8949
Relevant Lines: 10627

💛 - Coveralls

@arminsabouri arminsabouri force-pushed the bump-payjoin-1-0-0-rc-0 branch from c32fddd to 9f19941 Compare October 3, 2025 20:50
Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo publish --dry-run passes this PR rebased on 0b41b74 (which would be 5a2a3d039943e674d10aa27c79318f2bf58fcfd5)

ack c32fddd &

Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ack 9f19941

cargo publish --dry-run lgtm

Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9f19941

@arminsabouri arminsabouri merged commit a43acb1 into payjoin:master Oct 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants