Update to payjoin-0.21 #1
Conversation
DanGould
force-pushed
the
simplify
branch
2 times, most recently
from
98cba40 to
024b334
Compare
spacebear21
left a comment
spacebear21
left a comment
There was a problem hiding this comment.
I don't know much about FFI but this looks fairly straightforward.
Out of curiosity, is it possible to use bitcoin-ffi for the rust-bitcoin bindings instead of making our own?
|
Yes it is possible to depend on edit: see #3 |
Add compilation flags so tests don't cause build problems. Simplify lib.rs with `pub use ...::*` wildcards.
Add bitcoin, ohttp, request modules. Remove types module.
DanGould
force-pushed
the
simplify
branch
2 times, most recently
from
5ea6a5a to
53460a9
Compare
README.md
Outdated
|
|
||
| # Run the integration test | ||
| cargo test --package payjoin_ffi --test bitcoin_core_integration_test v1_to_v1_full_cycle | ||
| cargo test --package payjoin_ffi --test bitcoin_core_integration v1_to_v1_full_cycle |
There was a problem hiding this comment.
fixed by removing much of this section of the readme since we spin up using bitcoind crate now
src/send/uni.rs
Outdated
|
|
||
| #[uniffi::export] | ||
| impl SenderBuilder { | ||
| //TODO: Replicate all functions like this & remove duplicate code |
There was a problem hiding this comment.
Should we create a follow-up issue for this?
There was a problem hiding this comment.
shoot I thought I removed this. The TODO item is actually completed and I think was copied over from the original to make separate ffi/uniffi fns
Remove support for v1 send,receive code. Separate uniffi exports where wrappers are required in order to support payjoin-flutter and other non-uniffi bindings. Use procedural macros to define uniffi bindings. Irrelevant v1-to-v1 tests were removed.
|
|
||
| # Run the integration test | ||
| cargo test --package payjoin_ffi --test bitcoin_core_integration_test v1_to_v1_full_cycle | ||
| cargo test --package payjoin_ffi --test bdk_integration_test v1_to_v1_full_cycle |
There was a problem hiding this comment.
sorry i missed this one in my earlier review but this test is also obsolete.
2 participants
PYTHON INTEGRATION IS NOW WRONG! V1-to-V1 tests ARE NOW WRONG / USELESS, and were removed. these must be FIXED: payjoin/rust-payjoin#736. I have deleted the v1-to-v1 tests but they may be revived to satisfy v2.
Python is being ignored since our immediate goal is to get payjoin-flutter working