This repository was archived by the owner on Dec 19, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Update msrv to 1.85.0 in ohttp-relay #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@nothingmuch I have disabled the integration tests for now but when you get a chance maybe we can pair to get these across this finish-line or make a point to disable them until we transition away from some of these deps |
Collaborator
Author
|
The integration tests are failing due to some failure in the current layout to load the certificates. A single test All tests Details |
34b8b31 to
659f33c
Compare
This bumps the msrv for the ohttp relay up to 1.85.0. This changes comes following the debian stable update to a similar update and many other projects in the bitcoin world moving to a similar msrv. This commit does not make any updates to the dependencies yet.
This updates the tokio and hyper tungstenite msrvs to match the ohttp-relay msrv at 1.85.0.
This commit updates the mockito msrv and the api that changes as a result to match the new msrv for ohttp relay of 1.85.0
This commits updates dependencies to match the ohttp relay msrv that dont require source changes or ahve any significant updates to their features or apis.
Collaborator
|
Hey Ben, I force-pushed over your WIP commit which I think should be testable now |
4dd8526 to
1d15204
Compare
Continue to use ring's crypto by initializing the default provider.
Collaborator
Author
|
TACK on 1d15204 |
benalleng
commented
Aug 26, 2025
| let https = | ||
| ureq::AgentBuilder::new().tls_config(Arc::new(config)).proxy(proxy).build(); | ||
| // Convert to owned Vec and leak to get &'static [u8] | ||
| let cert_static = cert.to_vec().leak(); |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does .leak() avoid being considered "unsafe" rust?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the msrv of ohttp-relay as well as bumping the deps up to a higher version that still fall within the msrv the ecosystem has chosen.
This is a relatively new msrv version so all of the deps latest version stlll fallws within the msrv. perhaps there will be future versions that wont but hopefully we have some CI actions to prevent any breaking changes in the future.