Prevent expired sessions from panicing #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Found another place where it panics I am going to try to address |
arminsabouri
approved these changes
Aug 18, 2025
benalleng
force-pushed
the
expired-session-panic
branch
from
b4f68a2 to
bb2131f
Compare
arminsabouri
approved these changes
Aug 18, 2025
| write!(f, "Failed to post original payjoin proposal: '{}'.", e) | ||
| } | ||
| Self::ReplayError(e) => { | ||
| write!(f, "Payjoin replay failed: '{}'.", e) |
Collaborator
There was a problem hiding this comment.
Nit:
Suggested change
| write!(f, "Payjoin replay failed: '{}'.", e) | |
| write!(f, "Payjoin session replay failed: '{}'.", e) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17
This should prevent panics when getting expired sessions from the directory.