add simple signaling-server implemented using libdatachannel cpp-api #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-S
force-pushed
the
examples/signaling-server-libdatachannel-ws
branch
from
694689b to
7c04028
Compare
added simple signaling-server implemented using libdatachannel cpp-api
Tim-S
force-pushed
the
examples/signaling-server-libdatachannel-ws
branch
from
7c04028 to
8e3ba51
Compare
…-libdatachannel-ws
|
|
||
| // Check command line arguments. | ||
| for (int i = 1; i < argc; i++) { | ||
| if (strcmp(argv[i], "--help") == 0) { |
Owner
There was a problem hiding this comment.
You should not mix C functions in C++ when it is not necessary. Use std::string.
| for (int i = 1; i < argc; i++) { | ||
| if (strcmp(argv[i], "--help") == 0) { | ||
| const size_t len = strlen(argv[0]); | ||
| char *path = (char *)malloc(len + 1); |
Owner
There was a problem hiding this comment.
Same here, you should use new[], or better way, std::string.
|
|
||
| char *app_name = NULL; | ||
| // app_name = last_path_segment(path, "\\/"); | ||
| fprintf(stderr, |
Owner
There was a problem hiding this comment.
Same here, you should use std::cout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added simple signaling-server implemented using libdatachannel cpp-api